This repository was archived by the owner on Feb 16, 2024. It is now read-only.
Added loadURL and setProxy functionality#307
Open
true-zero wants to merge 15 commits intoasticode:masterfrom
Open
Added loadURL and setProxy functionality#307true-zero wants to merge 15 commits intoasticode:masterfrom
loadURL and setProxy functionality#307true-zero wants to merge 15 commits intoasticode:masterfrom
Conversation
asticode
suggested changes
Feb 3, 2021
asticode
suggested changes
Feb 5, 2021
| Username string `json:"username,omitempty"` | ||
| WindowID string `json:"windowId,omitempty"` | ||
| WindowOptions *WindowOptions `json:"windowOptions,omitempty"` | ||
| Proxy *WindowProxyOptions `json:"proxy,omitempty"` |
Owner
There was a problem hiding this comment.
Could you move this field upwards so that fields are sorted alphabetically?
window.go
Outdated
| EventNameWindowCmdWebContentsOpenDevTools = "window.cmd.web.contents.open.dev.tools" | ||
| EventNameWindowCmdWebContentsExecuteJavaScript = "window.cmd.web.contents.execute.javascript" | ||
| EventNameWindowCmdWebContentsSetProxy = "window.cmd.web.contents.set.proxy" | ||
| EventNameWindowCmdLoadURL = "window.cmd.load.url" |
Owner
There was a problem hiding this comment.
Could you move this field upwards so that fields are sorted alphabetically?
window.go
Outdated
| EventNameWindowEventWebContentsSetProxy = "window.event.web.contents.set.proxy" | ||
| EventNameWindowEventWillNavigate = "window.event.will.navigate" | ||
| EventNameWindowEventUpdatedCustomOptions = "window.event.updated.custom.options" | ||
| EventNameWindowLoadedURL = "window.event.loaded.url" |
Owner
There was a problem hiding this comment.
Name should be EventNameWindowEventLoadedURL (with Event in the middle)
Also could you move this field upwards so that fields are sorted alphabetically?
Owner
|
Can I close this PR or will you be working on it in the future? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.